-
Notifications
You must be signed in to change notification settings - Fork 409
add email-version hook to override detected Connect version
#14022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add email-version hook to override detected Connect version
#14022
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Looks good. Could you run |
|
Thanks @cscheid. I did notice the build step, but wasn't sure if I was meant to run it locally. I pushed all the changes it generated, but none were in the schema directory. Will revert it if that's not what you were looking for. edit: I must have committed the wrong files. |
|
(sorry, I gave you the wrong paths. This is strange. The error we're getting here seems (at least to me) to be unrelated. The files you've pushed are the ones I expected to see... |
|
I think Christophe just added the necessary changes to main; I wonder if a merge would solve it. |
2ab92db to
94522b0
Compare
|
🎉 If this is working for you within Connect, I'm fine with merging! |
|
Super, let's merge! It's working locally (where I don't have connect v2026.03 since it doesn't exist yet), so I'm as confident as I can be for now. |
Yes sorry. Windows / linux stuff againt Regarding conflict, a rebase is needed on main (or merging main in the branch) and resolving conflict by building schema artifacts again. Also, is a changelog entry needed maybe for this? |
Description
This PR makes embedding pre-releases of quarto into Connect (and vice versa) easier by allowing us to declare the version output Quarto should give, beyond the detected version. This makes it simpler to run Quarto on dev versions of Connect as we make staggered changes to Quarto email support, such as in #13882
closes #14021
By setting the above fields, even if Quarto detects that it is running inside an old version of Connect, it will output V2 style email metadata.
When rendered locally, I see V2 output metadata, despite having an old version of connect.
Checklist
I have (if applicable):
filed a contributor agreement.created a separate documentation PR in Quarto's website repo and linked it to this PR